Import AITURK IDE 1.0.0-beta.1 from Hermes 63279301; preserve MIT license
This commit is contained in:
@@ -0,0 +1,76 @@
|
||||
"""Tests for the fail-closed pre-write syntax gate on write_file.
|
||||
|
||||
Structured formats with an in-process linter (JSON/YAML/TOML) are validated
|
||||
BEFORE any bytes touch disk: a candidate write that doesn't parse is refused
|
||||
outright -- nothing lands on disk -- instead of being written and merely
|
||||
reported afterward via the post-write lint delta.
|
||||
|
||||
These run against a REAL LocalEnvironment (actual shell commands / actual
|
||||
files under tmp_path), matching the existing pattern in
|
||||
tests/tools/test_file_write_safety.py::TestAtomicWrite.
|
||||
"""
|
||||
|
||||
import json
|
||||
from pathlib import Path
|
||||
|
||||
import pytest
|
||||
|
||||
from tools.environments.local import LocalEnvironment
|
||||
from tools.file_operations import ShellFileOperations
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def ops(tmp_path: Path):
|
||||
env = LocalEnvironment(cwd=str(tmp_path))
|
||||
return ShellFileOperations(env, cwd=str(tmp_path))
|
||||
|
||||
|
||||
class TestFailClosedSyntaxGate:
|
||||
def test_invalid_json_refused_file_not_created(self, ops, tmp_path: Path):
|
||||
target = tmp_path / "config.json"
|
||||
res = ops.write_file(str(target), '{"a": 1,') # truncated / invalid
|
||||
assert res.error is not None
|
||||
assert "json" in res.error.lower()
|
||||
assert not target.exists(), "invalid JSON must NOT be written to disk"
|
||||
|
||||
|
||||
def test_valid_json_written_exactly(self, ops, tmp_path: Path):
|
||||
target = tmp_path / "config.json"
|
||||
content = json.dumps({"a": 1, "b": [1, 2, 3]})
|
||||
res = ops.write_file(str(target), content)
|
||||
assert res.error is None, res.error
|
||||
assert target.read_text() == content
|
||||
|
||||
|
||||
def test_invalid_python_is_NOT_hard_refused(self, ops, tmp_path: Path):
|
||||
"""Deliberate scope decision: .py keeps the pre-existing NON-BLOCKING
|
||||
lint-delta report rather than a hard refusal (see
|
||||
``_FAIL_CLOSED_INPROC_EXTS`` in tools/file_operations.py for why --
|
||||
this codebase's own test suite writes arbitrary non-Python content
|
||||
through *.py paths as generic write-mechanics fixtures)."""
|
||||
target = tmp_path / "broken.py"
|
||||
bad_python = "def foo(:\n pass\n"
|
||||
res = ops.write_file(str(target), bad_python)
|
||||
assert res.error is None, res.error
|
||||
assert target.read_text() == bad_python
|
||||
# Still surfaced via the (non-blocking) lint report:
|
||||
assert res.lint is not None
|
||||
assert res.lint.get("status") == "error"
|
||||
assert "SyntaxError" in res.lint.get("output", "")
|
||||
|
||||
|
||||
def test_custom_tagged_yaml_is_valid_and_written(self, ops, tmp_path: Path):
|
||||
"""Application-defined tags (CloudFormation !Sub/!Ref, Ansible !vault)
|
||||
are valid YAML syntax; only the *consumer* defines their constructors.
|
||||
The gate is syntax-only and must let them through."""
|
||||
target = tmp_path / "template.yaml"
|
||||
content = (
|
||||
"Resources:\n"
|
||||
" Bucket:\n"
|
||||
" Type: AWS::S3::Bucket\n"
|
||||
" Properties:\n"
|
||||
" BucketName: !Sub '${AWS::StackName}-bucket'\n"
|
||||
)
|
||||
res = ops.write_file(str(target), content)
|
||||
assert res.error is None, res.error
|
||||
assert target.read_text() == content
|
||||
Reference in New Issue
Block a user