Import AITURK IDE 1.0.0-beta.1 from Hermes 63279301; preserve MIT license

tests/tools/test_delegate_toolset_scope.py

@@ -0,0 +1,75 @@
+"""Tests for delegate_tool toolset scoping.
+
+Verifies that subagents cannot gain tools that the parent does not have.
+The LLM controls the `toolsets` parameter — without intersection with the
+parent's enabled_toolsets, it can escalate privileges by requesting
+arbitrary toolsets.
+"""
+
+from types import SimpleNamespace
+
+from tools.delegate_tool import _strip_blocked_tools, _emit_parent_console
+
+
+class TestToolsetIntersection:
+    """Subagent toolsets must be a subset of parent's enabled_toolsets."""
+
+    def test_requested_toolsets_intersected_with_parent(self):
+        """LLM requests toolsets parent doesn't have — extras are dropped."""
+        parent = SimpleNamespace(enabled_toolsets=["terminal", "file"])
+
+        # Simulate the intersection logic from _build_child_agent
+        parent_toolsets = set(parent.enabled_toolsets)
+        requested = ["terminal", "file", "web", "browser", "rl"]
+        scoped = [t for t in requested if t in parent_toolsets]
+
+        assert sorted(scoped) == ["file", "terminal"]
+        assert "web" not in scoped
+        assert "browser" not in scoped
+        assert "rl" not in scoped
+
+
+    def test_strip_blocked_removes_delegation(self):
+        """Blocked toolsets (delegation, clarify, etc.) are always removed."""
+        child = _strip_blocked_tools(["terminal", "delegation", "clarify", "memory"])
+        assert "delegation" not in child
+        assert "clarify" not in child
+        assert "memory" not in child
+        assert "terminal" in child
+
+    def test_empty_intersection_yields_empty_toolsets(self):
+        """If parent has no overlap with requested, child gets nothing extra."""
+        parent = SimpleNamespace(enabled_toolsets=["terminal"])
+
+        parent_toolsets = set(parent.enabled_toolsets)
+        requested = ["web", "browser"]
+        scoped = [t for t in requested if t in parent_toolsets]
+
+        assert scoped == []
+
+
+class TestEmitParentConsole:
+    """Progress lines (e.g. ``✓ [N/M] …``) must route through the parent's
+    configured ``_safe_print`` in headless stdio hosts (ACP, gateway) so
+    they don't land on stdout and corrupt JSON-RPC frames. Regression for a
+    bug where delegate_task completion lines pushed to stdout caused
+    ``Failed to parse JSON message: ✓ [3/3] …`` errors in the ACP adapter."""
+
+    def test_routes_through_parent_safe_print_when_available(self, capsys):
+        captured_lines = []
+        parent = SimpleNamespace(_safe_print=lambda line: captured_lines.append(line))
+
+        _emit_parent_console(parent, "  ✓ [1/3] Research done  (11.55s)")
+
+        assert captured_lines == ["  ✓ [1/3] Research done  (11.55s)"]
+        stdout_stderr = capsys.readouterr()
+        assert stdout_stderr.out == ""
+        assert stdout_stderr.err == ""
+
+
+    def test_non_callable_safe_print_is_ignored(self, capsys):
+        """Defensive: if _safe_print is set but not callable, fall back."""
+        parent = SimpleNamespace(_safe_print="not-a-function")
+        _emit_parent_console(parent, "  ✓ [3/3] non-callable guard")
+        captured = capsys.readouterr()
+        assert "non-callable guard" in captured.out