Import AITURK IDE 1.0.0-beta.1 from Hermes 63279301; preserve MIT license

tests/tools/test_build_subprocess_env.py

@@ -0,0 +1,142 @@
+"""Tests for tools.environments.local.build_subprocess_env — the single
+factory for child-process environments (profile-home + secret-scrub owner).
+"""
+
+import os
+import subprocess
+import sys
+
+import pytest
+
+from tools.environments.local import build_subprocess_env
+
+
+# ---------------------------------------------------------------------------
+# Unit: scrub path delegates to _sanitize_subprocess_env semantics
+# ---------------------------------------------------------------------------
+
+def test_scrub_on_strips_provider_key(monkeypatch):
+    monkeypatch.setenv("ANTHROPIC_API_KEY", "sk-secret")
+    env = build_subprocess_env()
+    assert "ANTHROPIC_API_KEY" not in env
+
+
+def test_scrub_on_strips_dynamic_internal_secret(monkeypatch):
+    monkeypatch.setenv("AUXILIARY_VISION_API_KEY", "sk-aux")
+    monkeypatch.setenv("GATEWAY_RELAY_FOO_TOKEN", "tok")
+    env = build_subprocess_env()
+    assert "AUXILIARY_VISION_API_KEY" not in env
+    assert "GATEWAY_RELAY_FOO_TOKEN" not in env
+
+
+def test_scrub_on_forwards_extra_like_sanitize_extra_env(monkeypatch):
+    env = build_subprocess_env(extra={"MY_HARMLESS_VAR": "1"})
+    assert env.get("MY_HARMLESS_VAR") == "1"
+    # extra still goes through the blocklist on the scrub path
+    env2 = build_subprocess_env(extra={"ANTHROPIC_API_KEY": "sk"})
+    assert "ANTHROPIC_API_KEY" not in env2
+
+
+# ---------------------------------------------------------------------------
+# Unit: no-scrub path preserves content exactly
+# ---------------------------------------------------------------------------
+
+
+def test_no_scrub_inherit_profile_home_bridges_context_override(tmp_path):
+    from hermes_constants import set_hermes_home_override, reset_hermes_home_override
+
+    token = set_hermes_home_override(str(tmp_path))
+    try:
+        env = build_subprocess_env(
+            {"PATH": "/bin"}, scrub_secrets=False, inherit_profile_home=True
+        )
+    finally:
+        reset_hermes_home_override(token)
+    assert env["HERMES_HOME"] == str(tmp_path)
+
+
+# ---------------------------------------------------------------------------
+# E2E: real subprocess sees the factory's contract
+# ---------------------------------------------------------------------------
+
+def test_e2e_child_sees_hermes_home_and_no_planted_secret(tmp_path, monkeypatch):
+    """A real child spawned with a factory-built env must see HERMES_HOME
+    propagated and (with scrub on) a planted provider-style key absent."""
+    hermes_home = tmp_path / "hermes-home"
+    hermes_home.mkdir()
+    monkeypatch.setenv("HERMES_HOME", str(hermes_home))
+    monkeypatch.setenv("ANTHROPIC_API_KEY", "sk-FAKE-planted")
+    monkeypatch.setenv("AUXILIARY_FAKE_API_KEY", "sk-FAKE-aux")
+
+    env = build_subprocess_env()  # scrub on (default)
+
+    code = (
+        "import os, json; "
+        "print(json.dumps({'home': os.environ.get('HERMES_HOME'), "
+        "'k1': 'ANTHROPIC_API_KEY' in os.environ, "
+        "'k2': 'AUXILIARY_FAKE_API_KEY' in os.environ}))"
+    )
+    out = subprocess.run(
+        [sys.executable, "-c", code],
+        env=env, capture_output=True, text=True, timeout=60, check=True,
+    )
+    import json
+
+    result = json.loads(out.stdout)
+    assert result["home"] == str(hermes_home)
+    assert result["k1"] is False
+    assert result["k2"] is False
+
+
+def test_e2e_no_scrub_child_keeps_planted_secret(tmp_path, monkeypatch):
+    monkeypatch.setenv("ANTHROPIC_API_KEY", "sk-FAKE-planted")
+    env = build_subprocess_env(scrub_secrets=False, inherit_profile_home=False)
+    out = subprocess.run(
+        [sys.executable, "-c",
+         "import os; print(os.environ.get('ANTHROPIC_API_KEY', ''))"],
+        env=env, capture_output=True, text=True, timeout=60, check=True,
+    )
+    assert out.stdout.strip() == "sk-FAKE-planted"
+
+
+# ---------------------------------------------------------------------------
+# E2E regression (#93082): cron/no_agent children keep bare `hermes` on PATH
+# ---------------------------------------------------------------------------
+
+
+def test_e2e_scrubbed_env_resolves_bare_hermes_under_minimal_parent_path(monkeypatch):
+    """Regression for #92998/#93082: a gateway launched by systemd/cron with a
+    minimal PATH (no hermes console-script dir) must still hand cron job
+    children an env whose PATH resolves bare ``hermes``.
+
+    Exercises the REAL factory and the REAL bin-dir resolver — no mocks of the
+    helpers. cron/scheduler._run_job_script builds its child env via exactly
+    this call (``build_subprocess_env()`` with scrub on).
+    """
+    import shutil
+
+    from tools.environments import local as local_mod
+
+    bin_dir = local_mod._resolve_hermes_bin_dir()
+    if not bin_dir or not os.path.isfile(
+        os.path.join(bin_dir, "hermes.exe" if os.name == "nt" else "hermes")
+    ):
+        pytest.skip("no real hermes console-script install available")
+
+    # Simulate the service-manager minimal PATH: hermes dir absent.
+    minimal_path = os.pathsep.join(["/usr/bin", "/bin"])
+    monkeypatch.setenv("PATH", minimal_path)
+    assert shutil.which("hermes", path=minimal_path) is None
+
+    env = build_subprocess_env(scrub_secrets=True)  # cron _run_job_script path
+
+    resolved = shutil.which("hermes", path=env.get("PATH", ""))
+    assert resolved is not None, (
+        f"bare 'hermes' must resolve from the child PATH {env.get('PATH')!r}"
+    )
+    assert os.path.dirname(resolved) == bin_dir
+    assert env["PATH"].split(os.pathsep)[0] == bin_dir
+    # Idempotent: running the parent env through the factory again must not
+    # duplicate the entry.
+    env2 = build_subprocess_env(env, scrub_secrets=True)
+    assert env2["PATH"].split(os.pathsep).count(bin_dir) == 1