Import AITURK IDE 1.0.0-beta.1 from Hermes 63279301; preserve MIT license

tests/test_gitlock.py

@@ -0,0 +1,139 @@
+"""Tests for hermes_cli.gitlock — stale git lock recovery + ancestry probe.
+
+These cover the two failure modes that produced the false "update available"
+notification and the hard ``update --check`` failure after a crashed fetch on
+a shallow clone:
+
+1. A stale ``.git/shallow.lock`` makes every later ``git fetch`` fail with
+   "File exists" unless cleared.
+2. On a shallow clone the update check compares tip SHAs, so local
+   cherry-picks on top of the remote tip look like "update available" even
+   though HEAD already contains the remote tip.
+
+The module's safety rules are also pinned: a *young* lock or a *running git
+process* must never be cleared.
+"""
+
+from __future__ import annotations
+
+import os
+import subprocess
+import time
+from pathlib import Path
+
+import pytest
+
+from hermes_cli.gitlock import (
+    LOCK_NAMES,
+    STALE_LOCK_MIN_AGE_SECONDS,
+    clear_stale_git_locks,
+    is_ancestor_of_head,
+)
+
+
+@pytest.fixture
+def repo(tmp_path: Path) -> Path:
+    """A real, tiny git repo with two commits (no network)."""
+    root = tmp_path / "repo"
+    root.mkdir()
+    subprocess.run(["git", "init", "-q"], cwd=root, check=True)
+    subprocess.run(["git", "config", "user.email", "test@example.com"], cwd=root, check=True)
+    subprocess.run(["git", "config", "user.name", "Test"], cwd=root, check=True)
+    (root / "a.txt").write_text("one\n")
+    subprocess.run(["git", "add", "a.txt"], cwd=root, check=True)
+    subprocess.run(["git", "commit", "-q", "-m", "first"], cwd=root, check=True)
+    (root / "b.txt").write_text("two\n")
+    subprocess.run(["git", "add", "b.txt"], cwd=root, check=True)
+    subprocess.run(["git", "commit", "-q", "-m", "second"], cwd=root, check=True)
+    return root
+
+
+def _touch(path: Path, age_seconds: float) -> None:
+    """Create (or truncate) a file and backdate its mtime."""
+    path.touch()
+    old = time.time() - age_seconds
+    os.utime(path, (old, old))
+
+
+@pytest.fixture
+def no_git_running(monkeypatch: pytest.MonkeyPatch) -> None:
+    """Pin the process guard: pretend no git process is running.
+
+    The removal tests exercise the sweep itself, not the guard.  Without
+    this pin they are flaky on CI: the parallel per-file test runner is
+    almost always running a real ``git`` subprocess somewhere, the
+    ``pgrep -x git`` probe hits, and the sweep (correctly) refuses to
+    remove anything — failing the assertion for reasons unrelated to the
+    code under test.  The guard's own behavior is pinned separately in
+    :func:`test_clear_skips_sweep_while_git_running`.
+    """
+    import hermes_cli.gitlock as gitlock
+
+    monkeypatch.setattr(gitlock, "_git_proc_running", lambda: False)
+
+
+def test_clear_removes_stale_shallow_lock(repo: Path, no_git_running: None) -> None:
+    _touch(repo / ".git" / "shallow.lock", STALE_LOCK_MIN_AGE_SECONDS + 60)
+    removed = clear_stale_git_locks(repo)
+    assert str(repo / ".git" / "shallow.lock") in removed
+    assert not (repo / ".git" / "shallow.lock").exists()
+
+
+def test_clear_removes_all_stale_lock_kinds(repo: Path, no_git_running: None) -> None:
+    for name in LOCK_NAMES:
+        _touch(repo / ".git" / name, STALE_LOCK_MIN_AGE_SECONDS + 60)
+    removed = clear_stale_git_locks(repo)
+    assert len(removed) == len(LOCK_NAMES)
+    for name in LOCK_NAMES:
+        assert not (repo / ".git" / name).exists()
+
+
+def test_clear_skips_sweep_while_git_running(repo: Path, monkeypatch: pytest.MonkeyPatch) -> None:
+    """A running git process must block the sweep even for stale locks."""
+    import hermes_cli.gitlock as gitlock
+
+    monkeypatch.setattr(gitlock, "_git_proc_running", lambda: True)
+    _touch(repo / ".git" / "shallow.lock", STALE_LOCK_MIN_AGE_SECONDS + 60)
+    removed = clear_stale_git_locks(repo)
+    assert removed == []
+    assert (repo / ".git" / "shallow.lock").exists()
+
+
+def test_clear_keeps_young_lock(repo: Path, no_git_running: None) -> None:
+    _touch(repo / ".git" / "shallow.lock", 1)  # 1 second old — presumably live
+    removed = clear_stale_git_locks(repo)
+    assert removed == []
+    assert (repo / ".git" / "shallow.lock").exists()
+
+
+def test_clear_noop_on_non_repo(tmp_path: Path) -> None:
+    bare = tmp_path / "not-a-repo"
+    bare.mkdir()
+    assert clear_stale_git_locks(bare) == []
+
+
+def test_clear_noop_with_no_locks(repo: Path) -> None:
+    assert clear_stale_git_locks(repo) == []
+
+
+def test_is_ancestor_true_for_first_commit(repo: Path) -> None:
+    first = subprocess.run(
+        ["git", "rev-list", "--max-parents=0", "HEAD"],
+        cwd=repo, capture_output=True, text=True, check=True,
+    ).stdout.strip()
+    assert is_ancestor_of_head(repo, first) is True
+
+
+def test_is_ancestor_true_for_head_itself(repo: Path) -> None:
+    head = subprocess.run(
+        ["git", "rev-parse", "HEAD"], cwd=repo, capture_output=True, text=True, check=True,
+    ).stdout.strip()
+    assert is_ancestor_of_head(repo, head) is True
+
+
+def test_is_ancestor_false_for_unknown_rev(repo: Path) -> None:
+    assert is_ancestor_of_head(repo, "deadbeef" * 5) is False
+
+
+def test_is_ancestor_false_for_nonexistent_repo(tmp_path: Path) -> None:
+    assert is_ancestor_of_head(tmp_path / "missing", "HEAD") is False