Import AITURK IDE 1.0.0-beta.1 from Hermes 63279301; preserve MIT license
This commit is contained in:
@@ -0,0 +1,40 @@
|
||||
"""Regression guard: a genuine Nous 429 must re-enter the retry loop so the
|
||||
top-of-loop Nous rate-limit guard can activate the fallback chain.
|
||||
|
||||
Bug (found in the #44061 audit): the genuine-rate-limit branch in
|
||||
``agent/conversation_loop.py`` set ``retry_count = max_retries`` then
|
||||
``continue``-d, intending the top-of-loop guard to "handle fallback or bail
|
||||
cleanly". But the loop condition is ``while retry_count < max_retries`` —
|
||||
setting retry_count equal to max_retries makes the condition False
|
||||
immediately, so the guard NEVER runs. No fallback activation, no clean
|
||||
rate-limit message: the turn dies with the generic retry-exhaustion error.
|
||||
|
||||
The fix sets ``retry_count = max(0, max_retries - 1)`` so the loop body runs
|
||||
exactly once more: the guard sees the breaker state recorded by
|
||||
``record_nous_rate_limit()`` moments earlier and either activates a fallback
|
||||
provider (resetting retry_count) or returns the explicit rate-limit failure.
|
||||
"""
|
||||
from __future__ import annotations
|
||||
|
||||
import inspect
|
||||
import re
|
||||
|
||||
|
||||
def _loop_reenters(retry_count: int, max_retries: int) -> bool:
|
||||
"""Mirror of the ``while retry_count < max_retries`` loop condition."""
|
||||
return retry_count < max_retries
|
||||
|
||||
|
||||
class TestGenuineNous429ReentersLoop:
|
||||
"""The assignment used by the genuine-429 branch must leave the loop
|
||||
condition True so the top-of-loop guard gets a chance to run."""
|
||||
|
||||
def test_fixed_assignment_reenters_for_typical_max_retries(self):
|
||||
for max_retries in (1, 2, 3, 5, 10):
|
||||
retry_count = max(0, max_retries - 1)
|
||||
assert _loop_reenters(retry_count, max_retries), (
|
||||
f"max_retries={max_retries}: guard would never run"
|
||||
)
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user