Import AITURK IDE 1.0.0-beta.1 from Hermes 63279301; preserve MIT license

tests/run_agent/test_malformed_tool_arguments.py

@@ -0,0 +1,97 @@
+"""Malformed model tool arguments are rejected at the dispatch boundary."""
+
+import json
+from types import SimpleNamespace
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+from run_agent import AIAgent
+
+
+def _make_agent() -> AIAgent:
+    tool_defs = [
+        {
+            "type": "function",
+            "function": {
+                "name": "web_search",
+                "description": "search",
+                "parameters": {"type": "object", "properties": {}},
+            },
+        }
+    ]
+    with (
+        patch("run_agent.get_tool_definitions", return_value=tool_defs),
+        patch("run_agent.check_toolset_requirements", return_value={}),
+        patch("hermes_cli.config.load_config", return_value={}),
+        patch("run_agent.OpenAI"),
+    ):
+        agent = AIAgent(
+            api_key="test-key-1234567890",
+            base_url="https://openrouter.ai/api/v1",
+            quiet_mode=True,
+            skip_context_files=True,
+            skip_memory=True,
+        )
+    agent.client = MagicMock()
+    agent._flush_messages_to_session_db = MagicMock()
+    return agent
+
+
+def _tool_call(call_id: str, arguments: str):
+    return SimpleNamespace(
+        id=call_id,
+        type="function",
+        function=SimpleNamespace(name="web_search", arguments=arguments),
+    )
+
+
+@pytest.mark.parametrize("dispatch_mode", ["sequential", "concurrent"])
+@pytest.mark.parametrize(
+    "bad_arguments",
+    [
+        pytest.param("not-json", id="malformed-json"),
+        pytest.param('"scalar"', id="scalar"),
+        pytest.param("[]", id="list"),
+        pytest.param("", id="empty"),
+        pytest.param('{"query": "cut off', id="truncated"),
+    ],
+)
+def test_malformed_arguments_are_rejected_without_blocking_valid_sibling(
+    dispatch_mode: str,
+    bad_arguments: str,
+):
+    agent = _make_agent()
+    assistant_message = SimpleNamespace(
+        content="",
+        tool_calls=[
+            _tool_call("call-bad", bad_arguments),
+            _tool_call("call-good", '{"query": "valid"}'),
+        ],
+    )
+    messages = []
+    executed = []
+
+    def fake_dispatch(name, args, task_id, *positional, **kwargs):
+        call_id = kwargs.get("tool_call_id") or (positional[0] if positional else None)
+        executed.append((name, args, call_id))
+        return json.dumps({"ok": args["query"]})
+
+    with (
+        patch("run_agent.handle_function_call", side_effect=fake_dispatch),
+        patch.object(agent, "_invoke_tool", side_effect=fake_dispatch),
+        patch(
+            "agent.tool_executor.maybe_persist_tool_result",
+            side_effect=lambda **kwargs: kwargs["content"],
+        ),
+    ):
+        execute = getattr(agent, f"_execute_tool_calls_{dispatch_mode}")
+        execute(assistant_message, messages, "task-1")
+
+    assert executed == [("web_search", {"query": "valid"}, "call-good")]
+    assert [message["tool_call_id"] for message in messages] == ["call-bad", "call-good"]
+    assert len([message for message in messages if message["tool_call_id"] == "call-bad"]) == 1
+
+    assert '"error": "Invalid tool arguments"' in messages[0]["content"]
+    assert "JSON object" in messages[0]["content"]
+    assert json.loads(messages[1]["content"]) == {"ok": "valid"}