Import AITURK IDE 1.0.0-beta.1 from Hermes 63279301; preserve MIT license
This commit is contained in:
@@ -0,0 +1,67 @@
|
||||
"""Regression test for TUI approval-prompt credential redaction (#48456).
|
||||
|
||||
Follow-up to #50767, which redacted the chat-platform and SSE/API approval
|
||||
transports. The TUI JSON-RPC transport is the third egress: three
|
||||
`register_gateway_notify` callbacks in `tui_gateway/server.py` emit the raw
|
||||
`approval_data` (with an unredacted `command`) to the TUI client. They now
|
||||
route through the module-level `_emit_approval_request` helper, which redacts
|
||||
`payload["command"]` via the shared `gateway.run._redact_approval_command` seam
|
||||
before emitting.
|
||||
"""
|
||||
|
||||
import inspect
|
||||
|
||||
import pytest
|
||||
|
||||
|
||||
class TestTuiApprovalEmitRedaction:
|
||||
def test_emit_approval_request_redacts_command_in_payload(self, monkeypatch):
|
||||
from tui_gateway import server as tui_server
|
||||
|
||||
emitted = {}
|
||||
monkeypatch.setattr(
|
||||
tui_server, "_emit",
|
||||
lambda event, sid, payload=None: emitted.update(
|
||||
{"event": event, "sid": sid, "payload": payload}
|
||||
),
|
||||
)
|
||||
raw = "curl -H 'Authorization: token ghp_01...6789' https://api.github.com"
|
||||
tui_server._emit_approval_request("sess-1", {"command": raw, "description": "x"})
|
||||
|
||||
assert emitted["event"] == "approval.request"
|
||||
# credential removed, non-command field + command structure preserved
|
||||
assert "ghp_01...6789" not in emitted["payload"]["command"]
|
||||
assert emitted["payload"]["description"] == "x"
|
||||
assert "github.com" in emitted["payload"]["command"]
|
||||
|
||||
@pytest.mark.parametrize(
|
||||
("allow_session", "allow_permanent", "expected"),
|
||||
[
|
||||
(True, True, ["once", "session", "always", "deny"]),
|
||||
(True, False, ["once", "session", "deny"]),
|
||||
(False, False, ["once", "deny"]),
|
||||
],
|
||||
)
|
||||
def test_emit_approval_request_honors_allowed_scopes(
|
||||
self, monkeypatch, allow_session, allow_permanent, expected
|
||||
):
|
||||
from tui_gateway import server as tui_server
|
||||
|
||||
emitted = {}
|
||||
monkeypatch.setattr(
|
||||
tui_server,
|
||||
"_emit",
|
||||
lambda event, sid, payload=None: emitted.update({"payload": payload}),
|
||||
)
|
||||
|
||||
tui_server._emit_approval_request(
|
||||
"sess-1",
|
||||
{
|
||||
"allow_permanent": allow_permanent,
|
||||
"allow_session": allow_session,
|
||||
"command": "<write to AGENTS.md>",
|
||||
},
|
||||
)
|
||||
|
||||
assert emitted["payload"]["choices"] == expected
|
||||
|
||||
Reference in New Issue
Block a user